Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for when user hasn't properly configured Pandora client #2317

Merged
merged 1 commit into from
Jun 18, 2016

Conversation

partofthething
Copy link
Contributor

Description:
In the Pandora component, the user is expected to have configured the client to auto-login with their credentials as described in the instructions. However, if the user does not do this, they would have gotten a cryptic error. This PR handles that situation, logs what the problem is, and recovers. If the user configures the client they can try turning on the media player a second time without restarting hass and it will work fine.

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob merged commit e7ea6ec into home-assistant:dev Jun 18, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants