Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Pushover parameters #2309

Merged
merged 2 commits into from
Jun 20, 2016
Merged

Add additional Pushover parameters #2309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc2c83
Add additional Pushover parameters
dale3h Jun 15, 2016
fe2cc2d
Remove data dictionary reference
dale3h Jun 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions homeassistant/components/notify/pushover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import logging

from homeassistant.components.notify import (
ATTR_TITLE, DOMAIN, BaseNotificationService)
ATTR_TITLE, ATTR_TARGET, ATTR_DATA, DOMAIN, BaseNotificationService)
from homeassistant.const import CONF_API_KEY
from homeassistant.helpers import validate_config

Expand Down Expand Up @@ -51,7 +51,17 @@ def send_message(self, message="", **kwargs):
"""Send a message to a user."""
from pushover import RequestError

# Make a copy and use empty dict as default value (thanks @balloob)
data = dict(kwargs.get(ATTR_DATA, {}))

data['title'] = kwargs.get(ATTR_TITLE)
target = kwargs.get(ATTR_TARGET)
if target is not None:
data['device'] = target

try:
self.pushover.send_message(message, title=kwargs.get(ATTR_TITLE))
self.pushover.send_message(message, **data)
except ValueError as val_err:
_LOGGER.error(str(val_err))
except RequestError:
_LOGGER.exception("Could not send pushover notification")