Envisalink support

[Cinntax]

Description:
This is a new platform, with several components to control and show the status of any alarm panel driven by the Eyez-on envisalink platform. This includes both DSC and Honeywell panels.

Related issue (if applicable): Enhancement request 409
https://community.home-assistant.io/t/dsc-alarm-integration/409

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

envisalink:
#optional
  port: 4025
  evl_version: 3
  keepalive_interval: 60
  zonedump_interval: 30

#required
  host: <envisalink IP address>
  panel_type: HONEYWELL or DSC
  user_name: <pass>
  password: <pass>
  code: '4015'

  zones:
    11:
      name: 'Back Door'
      type: 'opening'

    21:
      name: 'First Floor Motion'
      type: 'motion'

  partitions:
    1:
      name: 'Home Alarm'

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If code communicates with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[balloob]

Instead of doing all these error checks, you could consider using a voluptuous schema like for example MQTT uses. Naming it CONFIG_SCHEMA will trigger Home Assistant to validate your config before it arrives in setup(hass, config)

[balloob]

Oh, and using vol.Coerce(int) you can also force data to be an integer etc.

[balloob]

Wow good job 👍 A few minor comments but this looks very good! ⭐⭐⭐⭐⭐

[Cinntax]

Awesome- thanks! It's been a relatively long time in the making... Also, I'll get those commits squashed/documentation submitted- it was late, and I had to merge the dev branch in a few times during development, so the squash was not exactly trivial. I wanted to get it in front of you at least.

[balloob]

Looks like you violated some style guide lines. From your CI build: https://travis-ci.org/home-assistant/home-assistant/jobs/137997755#L197-L278

[Cinntax]

Oh- sorry wasn't quite ready for you to validate again- I'll get these fixed ASAP.

[Cinntax]

Alright, I'm all set! However I'm struggling quite a bit with getting everything squashed with the pulls I did in the middle- do you have any tricks for dealing with that?

[balloob]

If this is going to be a dictionary mapping integers (zone_num) to a schema, you can use this:

vol.Optional(CONF_ZONES): {vol.Coerce(int): ZONE_SCHEMA},

This will validate all keys as integers and each value against ZONE_SCHEMA.

[Cinntax]

Awesome- yes i was definitely trying to figure that out. When I couldn't- that's when I put further validation within the sensor/binary_sensor/alarm_panel. I'll take that logic back out since this is now working. It will make those codebases smaller/simpler.

[Cinntax]

Thanks for your help- these changes have been made. In terms of the squash- I'm actually wondering if pulling these commits into a new branch and re-submitting might be easiest/cleanest...

[balloob]

Don't worry about the squashing, GitHub has a built in option now to do it when I press merge.

[Cinntax]

Excellent- good to know. Thanks!