Stability improvement in Pandora and proper shutdown in LIRC #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added media_content_type reduced debug messages made more robust station list Eliminated auto-pause detection issue
2 tasks
|
Looks good! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a minor maintenance PR. In Pandora it solves an issue where the buffer from pexpect isn't empty when switching Pandora stations (because the time-ticker updated before pexpect got its expected prompt). It also solves an issue where the pause/play status was sometimes wrong. Also added proper media_content_type to get better display in frontend.
There are also a few info->debug conversions in LIRC and a new
deinitto wrap up more properly when shutting down.Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass