Catch ValueError

[fabaff]

Description:
The REST binary sensor was only able to handle 0 and 1 so far. This PR catches the ValueError if the return value is something else.

Related issue (if applicable): https://community.home-assistant.io/t/restful-binary-sensor-value-template/1779

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: rest
    resource: https://www.hamburg.ccc.de/dooris/status.json
    method: GET
    name: z9
    sensor_class: opening
    value_template: '{{ value_json.state.open }}'

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If code communicates with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• Tests have been added to verify that the new code works.

[balloob]

It should not be an else but always happen because it's a binary sensor and thus should be a boolean. Templates always return a string

[fabaff]

Right

[balloob]

Looks good! 🐬

[balloob]

You could have written this as:

return response.lower() in ('true', 'on', 'open', 'yes')