Wink Rollershutter #2294
Wink Rollershutter #2294
Conversation
philk
force-pushed
the
wink_rollershutter
branch
2 times, most recently
from
244f2a1 to
b4ddbf4
Compare
|
You stated that the current position isn't returned from the Wink API. In your python-wink json for the device it shows null as the position value. Are you getting null back? Do you know the position of the shades in the official Wink App? If so I think you are going to want to bring this up as a bug with Wink so they can get it fixed. Not knowing the position really sucks :( |
philk
force-pushed
the
wink_rollershutter
branch
from
b4ddbf4 to
0cbfc5b
Compare
|
Unfortunately it's a problem further upstream. The Somfy ZRTSI doesn't track and report status (since RTS is a unidirectional protocol) so there's no way for Wink to know it either. I can't find any confirmation about the Lutron Serena's (the only other shades supported by Wink) reporting status one way or the other. If you open the Wink app all blinds always show as closed. The Wink app internally keeps track of the shades (unless the app is closed/crashed/force quit, in which case it defaults back to closed) and will be inaccurate if you use the actual shade remotes. Note that in the app this is super annoying since you have to swipe the blinds open, then closed to close them. Whee! Wink... 😐 I did originally consider making this PR track state internally like the Wink app does but knowing how annoying that is in the Wink app when it's wrong it felt bad. You do make a good point that there's no reason to swallow the state at the home-assistant level (in case the Serena's are different). python-wink returns valid state if it exists so we might as well respect that. I've updated the PR with |
| @property | ||
| def should_poll(self): | ||
| """Wink Shades don't track their position.""" | ||
| return False |
There was a problem hiding this comment.
This should be True right? You have an update method that actually updates the state and you implement current_position
There was a problem hiding this comment.
It certainly could be True.
I've shot out a message to Wink support to see if the position will always be null from the API. If so I'd say this should remain as False since polling is just a waste.
|
Looks good! 🐬 |
Description:
Adds support for Wink shades/blinds using the rollershutter component.
Requires additions from python-wink 0.7.7 and it seemed like having a different version would probably break things so I updated
REQUIREMENTSin all the Wink components. I can squash that or put it in a separate PR if that's the way you all want to do things.I didn't see any tests for the other Wink components. If there's a good example of a similar component I could take a stab at that.
Pull request in home-assistant.io with documentation (if applicable):
home-assistant/home-assistant.io#559
Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass