Fixing MJPEG streaming in Werkzeug #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. I'm planning a hot fix for 0.21 and I'll include this fix. Thanks |
balloob
pushed a commit
that referenced
this pull request
Jun 12, 2016
|
@stjohnjohnson, I just upgraded again to 0.21.1, but the issue still occurs. The preview is working, and I get a live image when I click the camera image, but when I close that, the interface freezes. It happens on every device, and when I refresh the page, it keeps loading. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This fixes MJPEG streaming by changing the response to include
direct_passthrough.The only downside to this change was that I had to change how
Responseis passed intomjpeg_streamso that I could pass this flag.Related issue (if applicable): fixes #2260
Checklist:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests pass