sensor/gtfs: add sanity check, origin earlier than destination #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously experienced issues on routes where services operate in both directions. The query picked up not just paths where service goes from Origin -> Destination, but trips going Destination -> Origin, and shown bogus results. Ensure that this doesn't happen by requiring the origin station's stop_sequence value to be lower than the destination station.
|
Thanks! @robbiet480 could you review this? It makes sense to me but I have not enough knowledge about this part. |
|
Ah yeah, this fix is great! I must have missed this by only testing with BART. Thanks @imrehg! |
balloob
pushed a commit
that referenced
this pull request
Jun 12, 2016
Previously experienced issues on routes where services operate in both directions. The query picked up not just paths where service goes from Origin -> Destination, but trips going Destination -> Origin, and shown bogus results. Ensure that this doesn't happen by requiring the origin station's stop_sequence value to be lower than the destination station.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously experienced issues on routes where services operate in both directions. The query picked up not just paths where service goes from Origin -> Destination, but trips going Destination -> Origin,
and shown bogus results.
Ensure that this doesn't happen by requiring the origin station's
stop_sequencevalue to be lower than the destination station.Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass