Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owm schema #2256

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Owm schema #2256

merged 1 commit into from
Jun 9, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jun 8, 2016

Description:
Add missing key for validation.

Related issue (if applicable): fixes #2257

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@Danielhiversen
Copy link
Member

Danielhiversen commented Jun 8, 2016

I do not think this will work.
I think you should change this line
https://github.com/home-assistant/home-assistant/pull/2256/files#diff-8a21420c1a82d8d153cf9bf19a150501L76 to:
if forecast:
Since "forecast" now will be a boolean and not an integer anymore.

Edit: (1 == True) is probably True? So it probably will work

@fabaff
Copy link
Member Author

fabaff commented Jun 8, 2016

@Danielhiversen you are right but I changed it.

@balloob balloob merged commit 8e5da57 into home-assistant:dev Jun 9, 2016
@fabaff fabaff deleted the owm-schema branch June 9, 2016 05:46
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid config for [sensor.openweathermap]: [forecast]
3 participants