BT Home Hub 5 device tracker support

[lwis]

Description:

Support for the BT Home Hub 5 for tracking devices.

Looking for feedback as this is my first component addition to the project, I'll add the documentation PR before (if) this is merged.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#558

Example entry for configuration.yaml (if applicable):

device_tracker:
  platform: bt_home_hub_5
  host: 192.168.1.254
  interval_seconds: 10
  consider_home: 180
  track_new_devices: yes

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If code communicates with devices:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass

[balloobbot]

farcy v1.1

• 80: E501 line too long (128 > 79 characters)

[balloob]

The code seems fine. You will need to clean it up to adhere to linting standards. See the instructions above in the PR message.

[balloob]

Please follow the checklist in your own PR message. Still some steps left.

[lwis]

@balloob home-assistant/home-assistant.io#558 - all should be in order 🎱

[balloob]

Please add your file to .coveragerc

[lwis]

@balloob why would I need to add to the omissions? I've added a test, and coveralls is passing.

[balloob]

New components are not allowed to reduce test coverage or else they should
be added to coveragerc. Your test is pretty bogus anyway as a component
with the following code would pass…

def get_scanner(hass, config):
return 1

On Mon, Jun 13, 2016 at 9:21 AM, Lewis Juggins [email protected]
wrote:

@balloob https://github.com/balloob why would I need to the omissions?
I've added a test, and coveralls is passing.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2250 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABYJ2s8ZhYeJ2UkhiNEVayWDUYgwf0Rlks5qLYN-gaJpZM4IvGBm
.

PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

[lwis]

Fair enough, squashed and omitted the component. When I get some time I'll improve test coverage for the component.

[balloob]

Alrighty, looks bueno 🐬 🚀