-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Sony Bravia TV #2243
Conversation
This platform contains a lot of logic for communicating with the TV. It would be best to split this out into a separate library and add that library as a dependency. Nice use of the configurator component, though. 👍 That one definitely goes under-appreciated. |
Thank you regarding the configurator usage. I think that the configurator is a great piece for this kind of use cases. You should work on improving it to support more scenarios. |
@@ -0,0 +1,521 @@ | |||
# flake8: noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop
Yeah. We don't want any protocol parsing etc in this repo. That way other people that do not use HA will not be able to leverage your work and we will have to maintain protocol upgrades. |
Ok, the code has been updated according to your suggestions. |
It looks good. Please rebase on the latest |
Ok, done! |
You didn't rebase but merged the branch. Now it shows 23 files changed and I can no longer verify which changes this PR brings. Please fix it 👍 |
Ops, sorry! fixed! |
7f0bf64
to
ecf228f
Compare
@@ -1 +1 @@ | |||
Subproject commit 0e6dc25fcd09ad1150aab258f8d01491a8ee8db7 | |||
Subproject commit 77f4dd1fed3d29c7ad8960c704a748af80748a59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this from your PR.
- Move communication logic to a separate library at https://github.com/aparraga/braviarc.git - Added dependency and adapt the code according to that
Ok, done! Please review it again to check if everything looks cool now! |
Yep, all cool! 🐬 ⛄ 🌴 |
Hi Aparraga, Many thanks for building this component! It's (almost) working great! I copied the code to my custom sensor folder for now. I have a Sony Bravia KDL myself, connected to my WIFI network. When my TV is turned on, everything works great, however, when it's turned off the below error message is logged. This is obviously caused by the braviarc submitting a request while the host is not available. I started to fiddle around a bit myself to see whether i can first ping the host before submitting the request but haven't been able to solve it so far. You help would be appreciated.
|
Thank you Dennuuz, Problem with the ping is that Bravia responds to pings even if it's turned off. |
Description:
The braviatv platform allows you to control a Sony Bravia TV.
To add a Sony Bravia TV to your installation, add the following to your configuration.yaml file:
Configuration variables:
You will need to configure your TV to allow the Home Assistant for remote usage. To do that, ensure that your TV is turned on. Open the configuration popup on Home Assistant and enter whatever PIN (for example, 0000). After that, the TV will show you a PIN and the Home Assistant will allow you to re-enter a new PIN. Enter the PIN shown on your TV and your Home Assistant will be allowed for remote usage on your Sony Bravia TV.
Supported almost all Sony Bravia TV 2013 and newer at http://info.tvsideview.sony.net/en_ww/home_device.html#bravia
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass