Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zwave thermostat with multiple setpoints #2237

Merged
merged 3 commits into from
Jun 9, 2016
Merged

fix zwave thermostat with multiple setpoints #2237

merged 3 commits into from
Jun 9, 2016

Conversation

srirams
Copy link
Contributor

@srirams srirams commented Jun 4, 2016

Description: fix issue with zwave thermostats with multiple set points (one for cooling and one for heating). Also change operation property to return the current operating state rather than what mode its set at.

Related issue (if applicable): fixes #2189 (partially)

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@turbokongen
Copy link
Contributor

@srirams
Copy link
Contributor Author

srirams commented Jun 8, 2016

Ok I've done it and that made everything pass!

Thanks.

@balloob
Copy link
Member

balloob commented Jun 9, 2016

Looks good! 🐬

@balloob balloob merged commit 4a5ad24 into home-assistant:dev Jun 9, 2016
@balloob balloob mentioned this pull request Jun 9, 2016
8 tasks
@xenoxaos
Copy link

Not to go around raising a horse from the dead just to kick it some more...but this is now merged and upstream. Correct? Is there a configuration change I need to make. This may be PEBKAC, but I'm still seeing multiple instances.
screenshot from 2017-02-21 21-38-56

@srirams
Copy link
Contributor Author

srirams commented Feb 22, 2017

There have been many changes since this was committed and this is now in a new component so you should probably make a new bug report. I haven't used zwave in a while (waiting on some openzwave updates), but the last time I did there was still some issues with the way ha worked with my thermostat.

@home-assistant home-assistant locked and limited conversation to collaborators Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HVAC Component Set Point Display and Manipulation Issues
4 participants