Removed webcolors dependency in favor of dictionary lookup. #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| HASS_COLOR_MAX = 500 # mireds (inverted) | ||
| HASS_COLOR_MIN = 154 | ||
|
|
||
|
|
||
| def color_name_to_rgb(color_name): |
There was a problem hiding this comment.
- D202: No blank lines allowed after function docstring (found 1)
- D210: No whitespaces allowed surrounding docstring text
- D401: First line should be in imperative mood ('Convert', not 'Converts')
|
|
||
| HASS_COLOR_MAX = 500 # mireds (inverted) | ||
| HASS_COLOR_MIN = 154 | ||
|
|
||
|
|
||
| def color_name_to_rgb(color_name): | ||
| """Convert color name to RGB hex value.""" | ||
| colors = { |
There was a problem hiding this comment.
Please make this a constant in this module so that the Python interpreter will not be required to rebuild it every time this function is called.
There was a problem hiding this comment.
Good point. Moved to module. Thanks
| 'hot pink': (252, 15, 192), 'fuchsia': (255, 119, 255), | ||
| 'lavender': (181, 126, 220), 'indigo': (75, 0, 130), | ||
| 'maroon': (128, 0, 0), 'crimson': (220, 20, 60)} | ||
| try: |
There was a problem hiding this comment.
You can do this without a try.
hex_value = colors.get(color_name.lower())
if not hex_value:
_LOGGER.....
hex_value = (255, 255, 255)There was a problem hiding this comment.
Went with this suggestion to keep log message.
|
Looks good! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed webcolors module in favor of dictionary lookup.
Related issue (if applicable): fixes #
https://www.pivotaltracker.com/story/show/120785401
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass