Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config validation for group #2206

Merged
merged 2 commits into from
Jun 9, 2016
Merged

Improve config validation for group #2206

merged 2 commits into from
Jun 9, 2016

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Jun 2, 2016

Description:
Before an invalid entity id for groups generated this error message:

16-06-02 15:09:37 ERROR (MainThread) [homeassistant.bootstrap] Invalid config for [group]: Group petersroom is invalid: not a valid value for dictionary value @ data['entities'] for dictionary value @ data['group']

With this change it will be:

16-06-02 15:46:24 ERROR (MainThread) [homeassistant.bootstrap] Invalid config for [group]: Group petersroom is invalid: Entity ID group.tracke--rs is an invalid entity id for dictionary value @ data['entities'] for dictionary value @ data['group']

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@Danielhiversen Danielhiversen changed the title Improve config validation Improve config validation for group Jun 2, 2016
@balloob
Copy link
Member

balloob commented Jun 9, 2016

Totally missed this, looks good 🐬

@balloob balloob merged commit e44c2a4 into dev Jun 9, 2016
@balloob balloob deleted the improve_config_validation branch June 9, 2016 03:55
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants