-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netio Switch platform support #2181
Conversation
_LOGGER = logging.getLogger(__name__) | ||
|
||
DEPENDENCIES = ['http'] | ||
REQUIREMENTS = ['pynetio>=0.1.6'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it a fixed version
Our dev branch was broken for 24 hours and that's the moment that you branched off :( Please rebase on latest dev so only the tests broken by your commits show up. |
180d207
to
7333591
Compare
Closing and re-opening to trigger tests. |
@@ -105,6 +105,9 @@ def setup_platform(hass, config, add_devices_callback, discovery_info=None): | |||
|
|||
DEVICES[config[CONF_HOST]] = Device(dev, []) | |||
|
|||
# Throttle the update for all NetioSwitches of one Netio | |||
dev.update = util.Throttle(MIN_TIME_BETWEEN_SCANS)(dev.update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why I did not simply do this in the first time :)
with a bit of polishing Signed-off-by: eagleamon <[email protected]>
Unfortunately, the same tests are failing but are not related I think. |
Looks good! 🐬 |
Great! Thanks :)
|
Added support for Net4all Netio switches.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests passFlake8 linting ok.