ASUSWRT platform doesn't accept ssh login with password anymore

[ardzeus]

Home Assistant release (hass --version):
0.22.1

Python release (python3 --version):
3.5.1

Component/platform:
device_tracker/asuswrt

Description of problem:
ASUSWRT platform doesn't accept ssh login with password anymore. Same configuration worked with version 0.21 fine. Also SSH login from command line with same credentials works fine.

Expected:

Problem-relevant configuration.yaml entries and steps to reproduce:

device_tracker:
  platform: asuswrt
  host: 192.168.1.1
  protocol: ssh
  track_new_devices: no
  username: admin
  password: secretpassword

Traceback (if applicable):

16-06-20 20:08:01 ERROR (ThreadPool Worker 5) [homeassistant.components.device_tracker.asuswrt] Unexpected response from router: password refused

Additional info:

[fabaff]

There was commit (1381984#diff-41bc1d46d2c173881ec4cbc34ed9f472) which introduced support for public key authentication. Could be related...@mtreinish perhaps you can help here.

[mtreinish]

So I just gave it a try and I wasn't able to reproduce any issues with 0.22 using password auth, it worked fine for me. If you look at the patch which added public key auth support the actual login code path is the same, assuming you don't have a pub_key entry in the configuration.yaml so I'm not sure that's the problem.

That being said the specific error message in this case is coming from pexpect.pxssh directly: https://github.com/pexpect/pexpect/blob/master/pexpect/pxssh.py#L304-L310 when it gets the password prompt a second time on trying to login, pxssh assumes that's because of an incorrect password and raises an exception.

[ardzeus]

Actually there are three login attemps, not just one like pxssh should do. Could this be a dependency problem...

Log entries from the router:
Jun 21 20:08:24 dropbear[14210]: Child connection from 192.168.1.50:50628
Jun 21 20:08:24 dropbear[14210]: Bad password attempt for 'admin' from 192.168.1.50:50628
Jun 21 20:08:25 dropbear[14210]: Bad password attempt for 'admin' from 192.168.1.50:50628
Jun 21 20:08:25 dropbear[14210]: Bad password attempt for 'admin' from 192.168.1.50:50628
Jun 21 20:08:25 dropbear[14210]: Exit before auth (user 'admin', 3 fails): Exited normally

[linjef]

I am having the same problem, and do not believe it is a dependency problem.

For me, changing line 141 from

if self.pub_key:

to

if self.pub_key != 'None':

fixes the problem, but I do not have public key yet set up to test whether it breaks public key.

[mtreinish]

Oh, yep I see the bug now. It's the str() cast on https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/device_tracker/asuswrt.py#L87 I forgot python is weird and casts None to "None". You can change the if too, the only case where that'd break is if someone passed in their public key file path as "None". I can push a patch for that to fix it, @linjef unless you want to handle it since you found the issue.

[linjef]

@mtreinish , please do push the patch for it; you're probably most set up for it right now :)

[justyns]

I know I'm nitpicking, but shouldn't pub_key be named priv_key or preferably just ssh_key to avoid confusion?
Thanks for the patch though! I can confirm it fixed the original issue for me.