Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship source files for sourcemaps #123

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

adierkens
Copy link
Contributor

The dist/ contains source-maps, but the underlying source files aren't present which causes webpack to complain

WARNING in ./node_modules/storybook-dark-mode/dist/icons/Moon.js
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find source file '../../src/icons/Moon.tsx': Error: Can't resolve '../../src/icons/Moon.tsx' in '/Users/adierkens/Developer/rewrite/web/node_modules/storybook-dark-mode/dist/icons'
 @ ./node_modules/storybook-dark-mode/dist/Tool.js 59:29-52
 @ ./node_modules/storybook-dark-mode/dist/index.js
 @ ./packages/storybook/dist/esm/addons/docs/index.js
 @ ./packages/storybook/dist/esm/addons/index.js
 @ ./packages/storybook/dist/esm/index.js
 @ ./.storybook/config.js
 @ ./node_modules/@design-systems/storybook/.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./node_modules/@design-systems/storybook/.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true ./node_modules/storybook-addon-sketch/entry.js

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Sep 11, 2020
@hipstersmoothie hipstersmoothie merged commit 2fc5422 into hipstersmoothie:master Sep 11, 2020
@adierkens adierkens deleted the patch-1 branch September 11, 2020 20:15
@hipstersmoothie
Copy link
Owner

🚀 PR was released in v1.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants