Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(excel) from 2016 to 2024 with new formulae #4182

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

dannywinrow
Copy link
Contributor

Remove:

FALSE|0
MIDBs
SQL.REQUEST
TRUE|0

Add:

ARRAYTOTEXT
BYCOL
BYROW
CHOOSECOLS
CHOOSEROWS
DROP
EXPAND
FALSE
FILTER
HSTACK
IMAGE
ISOMITTED
LAMBDA
LET
MAKEARRAY
MAP
MIDB
RANDARRAY
REDUCE
SCAN
SEQUENCE
SORT
SORTBY
STOCKHISTORY
TAKE
TEXTAFTER
TEXTBEFORE
TEXTSPLIT
TOCOL
TOROW
TRUE
UNIQUE
VALUETOTEXT
VSTACK
WRAPCOLS
WRAPROWS
XLOOKUP
XMATCH

Changes

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

Remove:

FALSE|0
MIDBs
SQL.REQUEST
TRUE|0

Add:

ARRAYTOTEXT
BYCOL
BYROW
CHOOSECOLS
CHOOSEROWS
DROP
EXPAND
FALSE
FILTER
HSTACK
IMAGE
ISOMITTED
LAMBDA
LET
MAKEARRAY
MAP
MIDB
RANDARRAY
REDUCE
SCAN
SEQUENCE
SORT
SORTBY
STOCKHISTORY
TAKE
TEXTAFTER
TEXTBEFORE
TEXTSPLIT
TOCOL
TOROW
TRUE
UNIQUE
VALUETOTEXT
VSTACK
WRAPCOLS
WRAPROWS
XLOOKUP
XMATCH
@dannywinrow dannywinrow changed the title Update from 2016 to 2024 with new formulae update(excel) from 2016 to 2024 with new formulae Dec 5, 2024
src/languages/excel.js Outdated Show resolved Hide resolved
I have left in SQL.REQUEST, this was from an addin that was included in Excel pre-2010 and is no longer used.  Perhaps people want to highlight it in code for older Excel versions.

I've removed MIDBs - this was clearly a typo and should have been MIDB which I have added.

I've removed TRUE|0 and FALSE|0 and replaced them with TRUE and FALSE which are both callable as functions.  The "|0" does not appear in the original archived link, so unless you can think of a reason for it (perhaps it handles the fact that TRUE and FALSE are also valid data not as a function) I will leave removed.
@joshgoebel
Copy link
Member

Better! you'll need to add an entry to CHANGES also.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

2 files changed

Total change +278 B

View Changes
file base pr diff
es/languages/excel.min.js 2.21 KB 2.34 KB +139 B
languages/excel.min.js 2.21 KB 2.35 KB +139 B

@joshgoebel joshgoebel merged commit 05e8075 into highlightjs:main Dec 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants