fix(rust) emoji supported in single quote strings #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +51 B View Changes
|
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +49 B View Changes
|
tomsarry
approved these changes
Dec 6, 2024
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +45 B View Changes
|
joshgoebel
force-pushed
the
issue-3933-fix-emoji-in-single-quoted-strings-rust
branch
from
3c99ed7 to
e8a26b4
Compare
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +49 B View Changes
|
|
I’m not quite familiar with grammar format here, but it turns out this change seems to be very breaking for a lot of Rust code:
code example from Rust by Example |
|
11.11.0 is completely unusable like this, I guess this needs a revert and point release? |
|
Thanks for the link to the example test. Let me add that as a test case. I think I see what went wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #3933. Uses begin/end to wrap strings instead of a regex that tries to match the whole string - which we do not recommend - and this is why. Now emoji work "for free" because they are just more text inside an existing string.
Checklist
CHANGES.md