fix(parser) prevent gobbling of illegal newlines #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +28 B View Changes
|
2 tasks
joshgoebel
force-pushed
the
fix-gobbling-of-illegal-newlines
branch
from
e0f145b to
f542e90
Compare
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +25 B View Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4101.
Changes
In case
illegaldetects a 0 width match the only case that can happen is a $ matching right before a newline, so we now not only add 1 (so the parser keeps going) but we also inject the\nback into themodeBuffer.The only other case might be if someone is using look-ahead in a illegal, and we'll simply say that is not-necessary and also not supported.
Checklist
CHANGES.md