bug(coffeescript) fix freezing bug due to badly behaved regex #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcoscaceres Or you could approve also if you have time to review. Only pinging you since I consider freeze issues pretty serious but I'd still like to have more than just my eyeballs on this. |
|
Actually I just realized I can both release a new stable version and hold this open for review at the same time, so that's what I'm going to do. :-) The power of Git. |
|
This has been live in 9.18.1 for 5 days now with no reported issue. Going to merge and close this, but if anyone still seems an issue with it later we can always review. |
|
Looks sane. Sorry I'm late. |
|
Better late than never, so I've heard. :-p |
taufik-nurrohman
pushed a commit
to taufik-nurrohman/highlight.js
that referenced
this pull request
Feb 18, 2020
…ghtjs#2376) * bug(coffeescript) fix freezing bug due to badly behaved regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2375