Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display $ when the currency is USD #933

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fix: display $ when the currency is USD #933

merged 3 commits into from
Dec 10, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Dec 9, 2024

Display a dollar sign when the currency is USD.

@jooola jooola requested a review from a team as a code owner December 9, 2024 09:41
@jooola jooola changed the title fix: display $ with the currency is USD fix: display $ when the currency is USD Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.24%. Comparing base (dbcf45d) to head (363540e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   69.23%   69.24%           
=======================================
  Files         244      244           
  Lines       10640    10642    +2     
=======================================
+ Hits         7367     7369    +2     
  Misses       2605     2605           
  Partials      668      668           
Flag Coverage Δ
e2e 42.79% <0.00%> (-0.01%) ⬇️
unit 63.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 0d1f5e9 into main Dec 10, 2024
6 checks passed
@jooola jooola deleted the usd_mapping branch December 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants