Adjust curl retry and connection timeout handling #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the shimmed CNBs used in `heroku/builder` we have been seeing quite a few transient errors related to buildpacks downloading from S3. Adding appropriate retries and connection timeouts to all of our buildpack's curl usages should help with these, as well as make builds more reliable in general for users on Heroku, plus also anyone using a shimmed CNB locally with Pack CLI (where the network connection may be even less reliable). The `--retry-connrefused` option has been used since otherwise curl doesn't retry cases where the connection was refused. Ideally we would use `--retry-all-errors` which takes that one step further, however that option was only added in curl 7.71, so is only supported by Heroku-22+. For more on curl options, see: https://curl.se/docs/manpage.html GUS-W-11283397.
edmorley
commented
Jun 13, 2022
Malax
approved these changes
Jun 14, 2022
Merged
edmorley
added a commit
that referenced
this pull request
Jun 14, 2022
To pick up #240 & #241. GUS-W-11283397.
EtienneM
pushed a commit
to Scalingo/buildpack-jvm-common
that referenced
this pull request
Jul 21, 2022
In the shimmed CNBs used in `heroku/builder` we have been seeing quite a few transient errors related to buildpacks downloading from S3. Adding appropriate retries and connection timeouts to all of our buildpack's curl usages should help with these, as well as make builds more reliable in general for users on Heroku, plus also anyone using a shimmed CNB locally with Pack CLI (where the network connection may be even less reliable). The `--retry-connrefused` option has been used since otherwise curl doesn't retry cases where the connection was refused. Ideally we would use `--retry-all-errors` which takes that one step further, however that option was only added in curl 7.71, so is only supported by Heroku-22+. For more on curl options, see: https://curl.se/docs/manpage.html GUS-W-11283397.
EtienneM
pushed a commit
to Scalingo/buildpack-jvm-common
that referenced
this pull request
Jul 21, 2022
To pick up heroku#240 & heroku#241. GUS-W-11283397.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the shimmed CNBs used in
heroku/builderwe have been seeing quite a few transient errors related to buildpacks downloading from S3.Adding appropriate retries and connection timeouts to all of our buildpack's curl usages should help with these, as well as make builds more reliable in general for users on Heroku, plus also anyone using a shimmed CNB locally with Pack CLI (where the network connection may be even less reliable).
The
--retry-connrefusedoption has been used since otherwise curl doesn't retry cases where the connection was refused. Ideally we would use--retry-all-errorswhich takes that one step further, however that option was only added in curl 7.71, so is only supported by Heroku-22+.For more on curl options, see:
https://curl.se/docs/manpage.html
GUS-W-11283397.