Add support for distribution prefixes with non-patch release versions #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/distribution-select
branch
4 times, most recently
from
6524b87 to
2868b92
Compare
Malax
force-pushed
the
malax/distribution-select
branch
from
39bb2fc to
cb7cf7e
Compare
Malax
changed the title
edmorley
approved these changes
Jun 8, 2022
Malax
force-pushed
the
malax/distribution-select
branch
3 times, most recently
from
b0f039c to
f0a655a
Compare
Malax
force-pushed
the
malax/distribution-select
branch
from
f0a655a to
f1dd3cd
Compare
This was referenced Jun 9, 2022
edmorley
added a commit
to heroku/heroku-buildpack-gradle
that referenced
this pull request
Jun 10, 2022
The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
edmorley
added a commit
to heroku/heroku-buildpack-java
that referenced
this pull request
Jun 10, 2022
The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
edmorley
added a commit
to heroku/heroku-buildpack-clojure
that referenced
this pull request
Jun 13, 2022
The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
edmorley
added a commit
to heroku/heroku-buildpack-java
that referenced
this pull request
Jun 13, 2022
* Vendor buildpack-stdlib Since: - The buildpack-stdlib repo has been sunset/archived, so no future changes to it are expected. - It's a script rather than a binary and is a small file, so a great candidate for vendoring. - Downloading it at runtime causes more potential failures modes, as seen in heroku/heroku-buildpack-clojure#118 * Fix test failures on `main` The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
edmorley
added a commit
to heroku/heroku-buildpack-gradle
that referenced
this pull request
Jun 13, 2022
* Vendor buildpack-stdlib Since: - The buildpack-stdlib repo has been sunset/archived, so no future changes to it are expected. - It's a script rather than a binary and is a small file, so a great candidate for vendoring. - Downloading it at runtime causes more potential failures modes, as seen in heroku/heroku-buildpack-clojure#118 * Fix test failures on `main` The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
edmorley
added a commit
to heroku/heroku-buildpack-clojure
that referenced
this pull request
Jun 13, 2022
* Switch to the recommended regional S3 domain Whilst the global S3 endpoint (`s3.amazonaws.com`) still works, AWS now recommends using the appropriate regional endpoint to access the bucket: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#s3-legacy-endpoints Our buildpack buckets are in `us-east-1`, whose regional domain is `*.s3.us-east-1.amazonaws.com`: https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region GUS-W-11283397. * Fix test failures on `main` The test assertions need updating after: heroku/heroku-buildpack-jvm-common#239
EtienneM
pushed a commit
to Scalingo/buildpack-jvm-common
that referenced
this pull request
Jul 21, 2022
…heroku#239) * Add support for distribution prefixes with non-patch release versions * Update CHANGELOG * Improve output when using heroku distribution prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow OpenJDK distribution prefixes to be used in conjunction with major versions. Previously, a specific patch version was required when using a distribution prefix. In addition, an alias prefix for
openjdkwas introduced:heroku. The new prefix makes it more clear that it will select a build of OpenJDK that was built by Heroku.For example, previously unsupported version strings such as
zulu-11,openjdk-17orheroku-8are now supported and will resolve to the latest patch release of the specified major version.The
CHANGELOGwas updated for immediate release asv133.