Set the DYNO env var when running integration tests
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DYNO` env var is now set when running the built containers during this repo's integration tests. This means they more accurately reflect the Heroku environment, which is important since some of the getting started guides (eg Python's) use the presence of the `DYNO` env var to determine whether to enable production mode or not. In the Python getting started guide, if DYNO is not set, then the guide runs in debug mode, which means static assets can be dynamically fetched from the source, and so bypass the normal production assets serving mechanism. By setting `DYNO` the integration tests will now validate that the production assets have been generated (via the `manage.py collectstatic` command that is now automatically run by the Python CNB). GUS-W-14144906.
Malax
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DYNOenv var is now set when running the built containers during this repo's integration tests. This means they more accurately reflect the Heroku environment, which is important since some of the getting started guides (eg Python's) use the presence of theDYNOenv var to determine whether to enable production mode or not.In the Python getting started guide, if DYNO is not set then the guide runs in debug mode, which means static assets can be dynamically fetched from the source, and so bypass the normal production assets serving mechanism. By setting
DYNOthe integration tests will now validate that the production assets have been generated (via themanage.py collectstaticcommand that is now automatically run by the Python CNB).GUS-W-14144906.