Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.json 'scripts' entries can be strings #91

Merged
merged 2 commits into from
Jun 4, 2024
Merged

composer.json 'scripts' entries can be strings #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f2416
composer.json 'scripts' can be string
dzuelke Mar 22, 2024
8ee2ece
a little smoke test addition for 'scripts' for now
dzuelke Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions buildpacks/php/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `buildpack.toml` declaration of `[[stacks]]` has been replaced with `[[targets]]`, currently supporting Ubuntu 20.04 and 22.04 (both `amd64`)
- Bump versions of Composer and minimal PHP for bootstrapping to 2.7.6 and 8.3.7

### Fixed

- Strings should be allowed as values in `scripts` object in `composer.json` ([#90](https://github.com/heroku/buildpacks-php/issues/90))

## [0.1.2] - 2023-10-24

### Changed
Expand Down
7 changes: 7 additions & 0 deletions buildpacks/php/tests/fixtures/smoke/hello-world/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,12 @@
},
"config":{
"bin-dir": "sbin"
},
"scripts": {
"foo": "echo 'foo'",
"bar": [
"echo 'one'",
"echo 'two'"
]
}
}
1 change: 1 addition & 0 deletions composer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ pub struct ComposerBasePackage {
pub repositories: Option<Vec<ComposerRepository>>,
pub require: Option<HashMap<String, String>>,
pub require_dev: Option<HashMap<String, String>>,
#[serde_as(as = "Option<HashMap<_, OneOrMany<_, PreferOne>>>")]
dzuelke marked this conversation as resolved.
Show resolved Hide resolved
pub scripts: Option<HashMap<String, Vec<String>>>,
pub scripts_descriptions: Option<HashMap<String, String>>,
pub source: Option<ComposerPackageSource>,
Expand Down