Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime leaderboardListCursorFromRank function #1111

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add runtime leaderboardListCursorFromRank function #1111

merged 3 commits into from
Oct 20, 2023

Conversation

sesposito
Copy link
Member

@sesposito sesposito requested a review from zyro October 19, 2023 18:00
zyro
zyro requested changes Oct 20, 2023
View reviewed changes
server/runtime_go_nakama.go
if expiry < 0 {
return "", errors.New("expects expiry to equal or greater than 0")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate rank >= 1 too I think?

@sesposito sesposito merged commit 89c5849 into master Oct 20, 2023
2 checks passed
@sesposito sesposito deleted the spe/add-rank-cache-api branch October 20, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyro zyro zyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesposito @zyro