Add refresh_token support to NakamaClient.restore_session #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jonbonazza
reviewed
Apr 13, 2024
| # Returns a session. | ||
| static func restore_session(auth_token : String): | ||
| return NakamaSession.new(auth_token, false) | ||
| static func restore_session(auth_token : String, refresh_token: String): |
There was a problem hiding this comment.
The refresh_token parameter should probably default to ”” for backwards compatibility. It would also be useful for people not using refresh tokens.
jonbonazza
approved these changes
Apr 13, 2024
lugehorsam
reviewed
Apr 15, 2024
| ``` | ||
|
|
||
| It is recommended to store the auth token from the session and check at startup if it has expired. If the token has expired you must reauthenticate. The expiry time of the token can be changed as a setting in the server. | ||
| It is recommended to store the auth token and refresh token from the session and check at startup if it has expired. If the token has expired you can use the refresh token to refresh the session, after which you can save the new tokens. If both tokens have expired, you must reauthenticate. The expiry time of the tokens can be changed as a setting in the server. |
There was a problem hiding this comment.
Small edit:"...check at startup if they have expired. If the auth token has expired..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
refresh_tokenargument toNakamaClient.restore_session, allowing sessions to be refreshed directly from a restored state. Previously, usingclient.session_refresh_async(session)on a restored session would result in aRefresh token is requirederror.Key Changes:
NakamaClient.restore_sessionto accept arefresh_token.Fixes: #207