Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to append-timestamp option. #127

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Small fixes to append-timestamp option. #127

merged 5 commits into from
Jan 11, 2023

Conversation

fruffy
Copy link
Contributor

@fruffy fruffy commented Jan 9, 2023

It looks like the values from getState are strings, so an explicit comparison is necessary.

@fruffy fruffy changed the title Small fixes to optional timestamping. Small fixes to append-timestamp option. Jan 9, 2023
@ppizarror
Copy link

ppizarror commented Jan 9, 2023 •
edited
Loading

A very important PR as the current v1.2.6 still stores timestamp cache even if append-timestamp is false. See https://github.com/hendrikmuhs/ccache-action/actions/runs/3868686837/jobs/6594291219 @hendrikmuhs

hendrikmuhs
hendrikmuhs reviewed Jan 9, 2023
View reviewed changes
src/save.ts Outdated Show resolved Hide resolved
@hendrikmuhs hendrikmuhs merged commit 150e52a into hendrikmuhs:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruffy @ppizarror @hendrikmuhs