Skip to content

Commit

Permalink
Exclude rowid from filters for poly chart vega query only (#679)
Browse files Browse the repository at this point in the history
  • Loading branch information
johallar authored Oct 25, 2024
1 parent 7a13604 commit 740f6a9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 3 additions & 1 deletion dist/charting.js
Original file line number Diff line number Diff line change
Expand Up @@ -66233,7 +66233,9 @@ function rasterLayerPolyMixin(_layer) {
}
var allFilters = _layer.crossfilter().getFilter(layerName);
var otherChartFilters = allFilters.filter(function (f, i) {
return !_layer.dimension() || i !== _layer.dimension().getDimensionIndex() && f !== "" && f !== null;
return !_layer.dimension() || i !== _layer.dimension().getDimensionIndex() && f !== "" && f !== null &&
// Kinda hacky, we don't want to include rowId filter in vega query, but we want everything else
!f.includes("rowid");
});
var firstElem = true;
otherChartFilters.forEach(function (value) {
Expand Down
6 changes: 5 additions & 1 deletion src/mixins/raster-layer-poly-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,11 @@ export default function rasterLayerPolyMixin(_layer) {
const otherChartFilters = allFilters.filter(
(f, i) =>
!_layer.dimension() ||
(i !== _layer.dimension().getDimensionIndex() && f !== "" && f !== null)
(i !== _layer.dimension().getDimensionIndex() &&
f !== "" &&
f !== null &&
// Kinda hacky, we don't want to include rowId filter in vega query, but we want everything else
!f.includes("rowid"))
)

let firstElem = true
Expand Down

0 comments on commit 740f6a9

Please sign in to comment.