Adding entry for Publicsuffix flag #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radiofreejohn
suggested changes
Oct 28, 2020
| @@ -13069,20 +13069,15 @@ const { Cookie } = tough; | |||
| // it's possible to send these cookies to a domain someone could register after the fact, but | |||
| // for Heap, we need a parseable URI because internally we try to determine the right level to set | |||
| // a cookie, rather than having a known set of public suffix domains. | |||
| const FAKE_APP_URI = 'https://yourdomain.heap/'; | |||
| const FAKE_APP_URI = 'https://' + window.location.host; | |||
There was a problem hiding this comment.
Let's leave yourdomain.heap - it's fine since we're adding the new flag. I'm also not 100% sure you always get window.location.host on all hybrid web apps, so wary of using it.
| // original tests for this library included. | ||
| cookiejar.setCookieSync(Cookie.parse(cookie, {loose: true}), FAKE_APP_URI); | ||
| const store = new WebStorageCookieStore(localStorage); | ||
| const cookiejar = new tough.CookieJar(store); |
There was a problem hiding this comment.
Line 13076 is redundant, and can be removed
| cookiejar.setCookieSync(Cookie.parse(cookie, {loose: true}), FAKE_APP_URI); | ||
| const store = new WebStorageCookieStore(localStorage); | ||
| const cookiejar = new tough.CookieJar(store); | ||
| const cookiejar = new tough.CookieJar(store, false); //false here sets the rejectPublicSuffix flag |
There was a problem hiding this comment.
The argument that tough.CookieJar is expecting is an object with the flag names and values, like:
tough.CookieJar(store, {rejectPublicSuffix: false}); -- which is also nice because it's self documenting, unless you want to explain that we need that flag for Cordova compatibility.
| const cookiejar = new tough.CookieJar(store, false); //false here sets the rejectPublicSuffix flag | ||
| Object.defineProperty(document, "cookie", { | ||
| get() { | ||
| return cookiejar.getCookieStringSync(FAKE_APP_URI); |
There was a problem hiding this comment.
I think formatting got broken here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cordova having to add the PublicSuffix flag is annoying.