-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 280 characters #143
base: master
Are you sure you want to change the base?
Conversation
As Twitter has recently introduced support for 280 characters[1], bump up maximum character limit in twittering mode. While here, make the maximum character limit a defvar for ease of maintenance. Closes hayamiz#142 Footnotes: [1] https://blog.twitter.com/official/en_us/topics/product/2017/Giving-you-more-characters-to-express-yourself.html
Nice! Looks good to me. I would like it to be merged :) |
Thanks for that! Looks good to me as well. |
👍 |
This is incomplete solution. A CJK character such as "あ" consumes 2 counts, so CJK tweets are still limited to 140 chars. |
So, would 280 bytes be more correct? (I assume that symbol is a 2 byte unicode?) |
No, that's not. The "weighted length" is besed on the amount of information in one character, not related to the size of unicode's byte sequence. FYI, most of Japanese characters are 3 byte sequences. |
Thanks @iRi-E for the URL of the document. As all of you know, the implementation is not so simple as replacing 140 with 280.
Which character should be counted by the same way as Japanese? In fact, some other characters such as the Ethiopic ones and Cherokee ones also counted as similarly to Japanese. To implement this, I need the strict definition. |
In addition to 8e9e812, I think |
Thank you, @afukumoto . |
It works well, thank you! |
#142 is now closed and fixed, so I think this PR can be closed too. |
As Twitter has recently introduced support for 280 characters[1], bump up
maximum character limit in twittering mode. While here, make the maximum
character limit a defvar for ease of maintenance.
Closes #142
Footnotes:
[1] https://blog.twitter.com/official/en_us/topics/product/2017/Giving-you-more-characters-to-express-yourself.html