-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate path separator duplicates #10646
base: master
Are you sure you want to change the base?
Conversation
2d03f00
to
53fd7b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused: is the .md file a GitHub artifact, or did you really add two changelog.d
entries?
53fd7b0
to
ca61a07
Compare
Thanks for catching that mistake of mine @geekosaur. I let the Can we use a |
|
Reverting to draft while I settle some Windows versus POSIX file path issues. |
cc0cc78
to
1fd13df
Compare
- Manually replace path separators before anything else
- Can't print pilcrow so use grep char for marking end of line - Marking the start of line distinguishes "expected" intro from its content too, same for "output"
- Rename original concatOutput to lineBreaksToSpaces
- Sort language pragmas
1fd13df
to
c06ba60
Compare
Fixes #10645, a small Windows gotcha missed with #10546.
I really had to get into the weeds with this one. The
assertOutputContains
function was modifying the output but in a way not 'visible' enough. I've added anassertOn
function (thatassertOutputContains
calls) that takes aNeedleHaystack
configuration for how the search, expectation and display are made. I had wanted to add a pilcrow¶
for line endings but the terminal output is restricted to ASCII so I've marked line beginnings with^
and line endings with$
. The needle (the expected output fragment) is shown annotated this way as can the haystack (the output). The haystack is not shown annotated with line delimiters but can be.The
concatOutput
function, I've renamed tolineBreaksToSpaces
.significance: significant
in the changelog file.