UI - token expiration calculation #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
reviewed
Oct 1, 2018
| }; | ||
| this.set('expirationCalcTS', Date.now()); |
There was a problem hiding this comment.
We don't set this anymore now? Do we just calculate the expiration on the fly every time now?
There was a problem hiding this comment.
madalynrose
previously approved these changes
Oct 1, 2018
meirish
force-pushed
the
ui-token-expiration
branch
from
d153810 to
8436962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI was calculating the expiration of the vault token incorrectly - this changes it to use either the
lease_durationor thettlwhen calculating the expiration.Fixes #5390
Also fixes a visual glitch that was introduced in the 3.4 upgrade where you'd see both the logged in and logged out nav briefly when authenticating.