Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certificates from store if tidying revoked certificates #5231

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

jefferai
Copy link
Member

This will cause them to be removed even if they have not expired yet,
whereas before it would simply leave them in the store until they were
expired, but remove from revocation info.

@jefferai jefferai added this to the 0.11.1 milestone Aug 30, 2018
@jefferai jefferai changed the title Remove certificates from store if tidying revoked certificates [WIP] Remove certificates from store if tidying revoked certificates Aug 30, 2018
@jefferai jefferai force-pushed the tidy-revocation-storage branch from e0a2bce to c40d24a Compare August 30, 2018 17:28
This will cause them to be removed even if they have not expired yet,
whereas before it would simply leave them in the store until they were
expired, but remove from revocation info.
@jefferai jefferai force-pushed the tidy-revocation-storage branch from c40d24a to 2c03339 Compare August 30, 2018 17:32
@jefferai
Copy link
Member Author

Note for reviewers, this:

  1. Removes the revocation list bool. It was essentially redundant with tidy_revoked_certs.

  2. If we are removing a cert entry from the revoked list, also remove the cert store entry itself, rather than leave it around until it hits the tidy cert store case -- which could be never. Otherwise the cert, on fetch, will show up with a revocation time of 0.

  3. Change semantics such that we only clear out revoked certs if they are past the certificate's expiration time. This is somehwat of a behavior change, but the problem is that without this, we're essentially unrevoking certs if we clear out the revoked certs while they're still valid. It's one of those nasty things about CRLs and we were kind of giving users an out before but we shouldn't. If users don't like it, they should use shorter-lived certs as we suggest (and as the backend is really built to do), just like on the public internet, but this is the right thing to do.

@jefferai jefferai changed the title [WIP] Remove certificates from store if tidying revoked certificates Remove certificates from store if tidying revoked certificates Aug 30, 2018
@jefferai jefferai requested a review from chrishoffman August 30, 2018 17:38
@jefferai jefferai merged commit b4ab18b into master Sep 5, 2018
@jefferai jefferai deleted the tidy-revocation-storage branch September 5, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant