Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 'algorithm' instead of 'hash-algorithm' for HMAC #4604

Merged
merged 2 commits into from
May 21, 2018
Merged

use 'algorithm' instead of 'hash-algorithm' for HMAC #4604

merged 2 commits into from
May 21, 2018

Conversation

madalynrose
Copy link
Contributor

@madalynrose madalynrose commented May 21, 2018 •
edited
Loading

meirish
meirish approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@madalynrose madalynrose merged commit 6888781 into master May 21, 2018
@madalynrose madalynrose deleted the hmac-algorithm-fix branch May 21, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madalynrose @meirish