Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui kv preflight endpoints #4439

Merged
merged 10 commits into from
Apr 24, 2018
Merged

Ui kv preflight endpoints #4439

merged 10 commits into from
Apr 24, 2018

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Apr 24, 2018

This is the UI counterpart to #4430 and #4435.
screen shot 2018-04-24 at 4 27 50 pm

The major change here is replacing calls to sys/mounts with sys/internal/ui/mounts and sys/internal/ui/mounts/:path - so we no longer need a fetch at the top level secrets route, and when loading individual secrets, we only need to lookup the path for the engine they're trying to view, not the whole list and then filtering for it.

The net effect is that we no longer need policy access to sys/mounts for the UI to function. As a bonus we also get a list of only the mounts that contain secrets that you have ACLs to operate on.

Here's a concrete example: Given a Vault instance with a kv backend mounted at kv/, a user logged in with a token policy of only the default policy plus a policy containing:

path "kv/*" {
  capabilities = ["create", "read", "list", "update", "delete"]
}

Would see this:
screen shot 2018-04-22 at 10 37 03 pm

@meirish meirish added this to the 0.10.1 milestone Apr 24, 2018
@meirish meirish requested review from a team April 24, 2018 03:25
@meirish meirish force-pushed the ui-kv-preflight-endpoints branch from 26f9a8f to 5fdfd8a Compare April 24, 2018 14:35
@meirish meirish force-pushed the ui-kv-preflight-endpoints branch from 5fdfd8a to 2c34a96 Compare April 24, 2018 21:21
@meirish meirish merged commit 1489293 into master Apr 24, 2018
@meirish meirish deleted the ui-kv-preflight-endpoints branch April 24, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant