Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin/gRPC: fix panic when special paths are not set #3946

Merged
merged 2 commits into from
Feb 9, 2018
Merged

plugin/gRPC: fix panic when special paths are not set #3946

merged 2 commits into from
Feb 9, 2018

Conversation

briankassouf
Copy link
Contributor

No description provided.

@briankassouf briankassouf requested a review from calvn February 9, 2018 00:16
vishalnayak
vishalnayak approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briankassouf briankassouf merged commit 5ccb347 into master Feb 9, 2018
@briankassouf briankassouf deleted the fix-grpc-special-paths branch February 9, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@jefferai jefferai jefferai approved these changes

@calvn calvn Awaiting requested review from calvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briankassouf @jefferai @vishalnayak