Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable client certificate requesting. #3373

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add option to disable client certificate requesting. #3373

merged 1 commit into from
Sep 25, 2017

Conversation

jefferai
Copy link
Member

Fixes #3372

@jefferai jefferai added this to the 0.8.3 milestone Sep 25, 2017
calvn
calvn approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vishalnayak
vishalnayak approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvn
Copy link
Contributor

calvn commented Sep 25, 2017

Not related to this PR, but travis caught a data race:

==================
WARNING: DATA RACE
Write at 0x00c4238a6748 by goroutine 545:
  github.com/hashicorp/vault/vault.TestTokenStore_CreateLookup_ExpirationInRestoreMode()
      /home/travis/gopath/src/github.com/hashicorp/vault/vault/token_store_test.go:569 +0xcf7
  testing.tRunner()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:746 +0x16c

Previous read at 0x00c4238a6748 by goroutine 611:
  github.com/hashicorp/vault/vault.(*ExpirationManager).Restore.func2()
      /home/travis/gopath/src/github.com/hashicorp/vault/vault/expiration.go:338 +0x99

Goroutine 545 (running) created at:
  testing.(*T).Run()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:789 +0x568
  testing.runTests.func1()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:1004 +0xa7
  testing.tRunner()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:746 +0x16c
  testing.runTests()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:1002 +0x521
  testing.(*M).Run()
      /home/travis/.gimme/versions/go1.9.linux.amd64/src/testing/testing.go:921 +0x206
  main.main()
      github.com/hashicorp/vault/vault/_test/_testmain.go:632 +0x1d3

Goroutine 611 (finished) created at:
  github.com/hashicorp/vault/vault.(*ExpirationManager).Restore()
      /home/travis/gopath/src/github.com/hashicorp/vault/vault/expiration.go:314 +0x407
==================
--- FAIL: TestTokenStore_CreateLookup_ExpirationInRestoreMode (0.15s)
	testing.go:699: race detected during execution of test

@jefferai
Copy link
Member Author

@calvn can you open a new issue about that and assign to Chris?

@calvn
Copy link
Contributor

calvn commented Sep 25, 2017 •
edited
Loading

Created #3375 to track that issue.

@jefferai jefferai modified the milestones: 0.8.3, 0.8.4 Sep 25, 2017
@jefferai jefferai merged commit 6faf836 into master Sep 25, 2017
@jefferai jefferai deleted the issue-3372 branch September 25, 2017 18:41
@chrishoffman chrishoffman mentioned this pull request Oct 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@calvn calvn calvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @vishalnayak