Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang.org/x/crypto to v0.31.0 #29153

Merged
merged 1 commit into from
Dec 12, 2024
Merged

bump golang.org/x/crypto to v0.31.0 #29153

merged 1 commit into from
Dec 12, 2024

Conversation

mickael-hc
Copy link
Contributor

mitigates CVE-2024-45337 which does not affect Vault (Vault does not use the affected functionality) but will help reduce scanner noise

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

mitigates CVE-2024-45337 which does not affect Vault but will help reduce scanner noise
@mickael-hc mickael-hc requested a review from a team as a code owner December 11, 2024 19:07
@mickael-hc mickael-hc requested a review from rebwill December 11, 2024 19:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 11, 2024
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but do make sure to backport this to 1.16, 1.17, 1.18 (as per the requirement for any security thing) -- make sure our dependencies are at the same levels too.

@mickael-hc mickael-hc added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent pr/no-changelog pr/no-milestone labels Dec 11, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@mickael-hc
Copy link
Contributor Author

@VioletHynes would you mind merging this one ? I don't have merge rights on this repo

@VioletHynes
Copy link
Contributor

Oh, sorry! I thought you did. Will do!

@VioletHynes VioletHynes merged commit 11708f1 into main Dec 12, 2024
110 of 118 checks passed
@VioletHynes VioletHynes deleted the bump-x/crypto branch December 12, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants