Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oss stub for autoloaded getter in core #29024

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

helenfufu
Copy link
Contributor

@helenfufu helenfufu commented Nov 25, 2024

Description

This PR adds the OSS stub for the autoloaded license getter in the core.

Related ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7056
Ticket: VAULT-30006
RFC: https://go.hashi.co/rfc/vlt-337

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 25, 2024
@helenfufu helenfufu requested a review from thyton November 25, 2024 22:56
Copy link

github-actions bot commented Nov 25, 2024

CI Results:
All Go tests succeeded! ✅

@helenfufu helenfufu added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 25, 2024
@helenfufu helenfufu added this to the 1.19.0-rc milestone Nov 25, 2024
@helenfufu helenfufu marked this pull request as ready for review November 25, 2024 23:21
@helenfufu helenfufu requested a review from a team as a code owner November 25, 2024 23:21
Copy link
Contributor

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Build Results:
All builds succeeded! ✅

@helenfufu helenfufu merged commit 33ccf6e into main Nov 25, 2024
109 of 136 checks passed
@helenfufu helenfufu deleted the vault-300006-add-autoloaded-getter-to-core branch November 25, 2024 23:46
Monkeychip pushed a commit that referenced this pull request Nov 27, 2024
* add oss stub for autoloaded getter in core

* add changelog
thyton added a commit that referenced this pull request Dec 11, 2024
@thyton thyton mentioned this pull request Dec 11, 2024
6 tasks
thyton added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants