-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/secrets sync ssrf private endpoints #28746
Conversation
…e guide The Secrets Sync feature in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. This adds documentation about the change and available options.
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
CI Results: |
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor suggestions.
website/content/partials/known-issues/1_17_secrets-sync-ssrf-private-endpoints.mdx
Show resolved
Hide resolved
website/content/partials/known-issues/1_17_secrets-sync-ssrf-private-endpoints.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepted all changes
* docs: add Secrets Sync SSRF protection breaking change to 1.17 upgrade guide The Secrets Sync feature in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. This adds documentation about the change and available options. * renamed issue * referenced secret sync ssrf known issue * re-ordered secret sync known issue in page * Hide copy-to-clipboard button on the output example codeblock --------- Co-authored-by: yhyakuna <[email protected]>
* docs: add Secrets Sync SSRF protection breaking change to 1.17 upgrade guide The Secrets Sync feature in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. This adds documentation about the change and available options. * renamed issue * referenced secret sync ssrf known issue * re-ordered secret sync known issue in page * Hide copy-to-clipboard button on the output example codeblock --------- Co-authored-by: yhyakuna <[email protected]>
* Docs/secrets sync ssrf private endpoints (#28746) * docs: add Secrets Sync SSRF protection breaking change to 1.17 upgrade guide The Secrets Sync feature in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. This adds documentation about the change and available options. * renamed issue * referenced secret sync ssrf known issue * re-ordered secret sync known issue in page * Hide copy-to-clipboard button on the output example codeblock --------- Co-authored-by: yhyakuna <[email protected]> * Remove extra include --------- Co-authored-by: James <[email protected]>
* Docs/secrets sync ssrf private endpoints (#28746) * docs: add Secrets Sync SSRF protection breaking change to 1.17 upgrade guide The Secrets Sync feature in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. This adds documentation about the change and available options. * renamed issue * referenced secret sync ssrf known issue * re-ordered secret sync known issue in page * Hide copy-to-clipboard button on the output example codeblock --------- Co-authored-by: yhyakuna <[email protected]> * Fix build issue --------- Co-authored-by: James <[email protected]>
🔍 Deploy preview
The Secrets Sync update in 1.17.3 introduced SSRF protection that blocks private IP ranges, affecting users accessing secret stores through private endpoints. Adding documentation about the change
Description
This PR adds documentation to the 1.17.x upgrade guide about a breaking change in Secrets Sync introduced in version 1.17.3. The documentation:
This change helps users understand why their Secrets Sync operations might fail after upgrading to 1.17.3 and what options are available to them.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.