UI: add allow_empty_principals to ssh engine (fixes failing test)
#28484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
added
ui
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Sep 24, 2024
| @@ -3,84 +3,73 @@ | |||
| SPDX-License-Identifier: BUSL-1.1 | |||
| ~}} | |||
|
|
|||
| <form {{on "submit" (perform this.save)}} aria-label="save ssh creds" data-test-configure-form> | |||
| <div class="box is-fullwidth is-shadowless is-marginless"> | |||
There was a problem hiding this comment.
removed lots of extra divs here, also the the box shadow above the input is anti-pattern so I removed it
before/after
hellobontempo
commented
Sep 24, 2024
Comment on lines
-11
to
-13
| <p class="has-text-grey-dark"> | ||
| NOTE: You must delete your existing certificate and key before saving new values. | ||
| </p> |
There was a problem hiding this comment.
moved this down, inside the {{else}} block
hellobontempo
commented
Sep 24, 2024
| {{else}} | ||
| {{! Model is not new and keys have already been created. Require user deletes the keys before creating new ones }} | ||
| <div class="box is-fullwidth is-sideless is-marginless" data-test-edit-config-section> |
There was a problem hiding this comment.
before/after
hellobontempo
commented
Sep 24, 2024
| @@ -76,48 +76,41 @@ | |||
| <MessageError @model={{this.model}} /> | |||
| <NamespaceReminder @mode="sign" @noun="SSH key" /> | |||
| {{#if this.model.attrs}} | |||
| {{#each (take 1 this.model.attrs) as |attr|}} | |||
There was a problem hiding this comment.
cleaned up divs, added subtext and moved valid_principals outside of the more options toggle because typically it will be required
|
Build Results: |
hellobontempo
commented
Sep 24, 2024
| @@ -40,6 +40,7 @@ const CA_FIELDS = [ | |||
| 'defaultExtensions', | |||
| 'allowBareDomains', | |||
| 'allowSubdomains', | |||
| 'allowEmptyPrincipals', | |||
There was a problem hiding this comment.
added to CA roles and in the more options toggle
hellobontempo
changed the title
allow_empty_principals to ssh engine (fix tests)allow_empty_principals to ssh engine (fixes failing test)
|
CI Results: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#28466 Added
allow_empty_principalsto the ssh engine. Though it's recommended to keep this valuefalsewe've added for parity with the backend. Also, an acceptance test was failing because avalid_principalswas not provided and is now required.TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.