Audit: log 'warnings' from eventlogger even if audit is deemed a success #27809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
core/audit
hashicorp-contributed-pr
peteski22
added
backport/ent/1.16.x+ent
|
CI Results: |
|
Build Results: |
VioletHynes
approved these changes
Jul 18, 2024
|
Oh, this might want a CE changelog too @peteski22 |
👍🏼 yep yep! I added this https://github.com/hashicorp/vault/pull/27809/files#diff-c91b41b277ccf0d8e61aff58a4f8672a1fb3540d68120dfcf9bb2bc754adda2a |
6 tasks
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ess (#27809) * make sure we still log underyling pipeline errors even if audit is deemed a success * changelog
Monkeychip
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ess (#27809) * make sure we still log underyling pipeline errors even if audit is deemed a success * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Within
auditthere exists an scenario where theeventloggerbroker reports that audit was deemed a success (because it managed to successfully log to at least 1 sink node), but there were warnings (errors) that came back from other audit devices where audit failed.We want to ensure that we capture these warnings in the server log so that they don't go missing because we managed to log to a single device.
This PR has ENT and CE components.
HashiCorp Checklist
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
Jira: If this change has an associated Jira, it's referenced eitherin the PR description, commit message, or branch name.
RFC: If this change has an associated RFC, please link it in the description.description. Also, make sure the changelog is in this PR, not in your ENT PR.