UI: Update resultant-acl banner #25256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
Monkeychip
reviewed
Feb 7, 2024
| } | ||
| const namespace = this.baseNs; | ||
| const allowed = | ||
| Object.keys(this.globPaths).any((k) => k.startsWith(namespace)) || |
There was a problem hiding this comment.
For someone not super familiar with this response, could you maybe add a comment with an example of glob vs exact paths? Especially since the API doc are 🙃 in information for this endpoint. Found this stackoverflow with someones examples to help me visual it.
There was a problem hiding this comment.
I think the best example is in the test file
I'd love to make this service glimmer + typescript, but since this change will be backported that will have to be a follow on
Monkeychip
approved these changes
Feb 7, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Request resultant-acl only from users root namespace * Update permissions adapter to always call resultant-acl at users root, with test * Update resultant-acl to accept failType * Update permissions service to set permissionsBanner based on resultant-acl contents * wire it up * add changelog * cleanup unused adapter changes * use getter for shared namespace logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates when the resultant-acl banner is shown to a user.
Before, we were always calling
resultant-aclat the current namespace. This typically would fail when the user is accessing a child namespace that they have access to, unless the administrator specifically gave them read access to the resultant-acl path within that namespace. This is a subpar experience for both users and administrators.With this change:
ns1, my resultant-acl call will always be made to namespacens1regardless of the namespace I'm currently accessingWhen accessing a namespace that is not in your policy:
When logged in with a user that does not have the default policy attached
