Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc/provider: adds code_challenge_methods_supported to metadata #24979

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

austingebauer
Copy link
Contributor

This PR adds code_challenge_methods_supported to Vault OIDC provider metadata. See rfc8414#section-2 for a description of the metadata value and code_challenge_method for the methods we accept.

Resolves: #24854

@austingebauer austingebauer added this to the 1.16.0-rc1 milestone Jan 22, 2024
@austingebauer austingebauer requested a review from a team as a code owner January 22, 2024 16:42
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 22, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC Provider does not publish code_challenge_methods_supported in openid metadata
2 participants