Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix PKI issuer capabilities #24686

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Conversation

hashishaw
Copy link
Contributor

There was a bug where capabilities on PKI issuers were incorrectly calculated. The workflow tests did not catch this because we weren't clearing the store of capabilities entries after setup, which means the UI was using the old capabilities in memory from the root setup.

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.14.x labels Jan 5, 2024
@hashishaw hashishaw added this to the 1.14.9 milestone Jan 5, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 5, 2024
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling. Curious if this was caught in the ember-data upgrade?

@hashishaw
Copy link
Contributor Author

Thank you for tackling. Curious if this was caught in the ember-data upgrade?

@Monkeychip it was actually the ember-exam PR!

@hashishaw hashishaw enabled auto-merge (squash) January 5, 2024 17:04
@hashishaw hashishaw disabled auto-merge January 5, 2024 17:15
Copy link

github-actions bot commented Jan 5, 2024

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw enabled auto-merge (squash) January 5, 2024 17:26
@hashishaw hashishaw merged commit d5af065 into main Jan 5, 2024
71 checks passed
@hashishaw hashishaw deleted the ui/fix-pki-issuer-capabilities branch January 5, 2024 20:40
Monkeychip pushed a commit that referenced this pull request Jan 5, 2024
Monkeychip pushed a commit that referenced this pull request Jan 5, 2024
Monkeychip pushed a commit that referenced this pull request Jan 7, 2024
hashishaw added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants