Buffer authhandler output channel to prevent hang on shutdown (#5507)

Fixes #5026
hashicorp · Oct 15, 2018 · d7655a9 · d7655a9
1 parent 574a08c
commit d7655a9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/command/agent/auth/auth.go b/command/agent/auth/auth.go
@@ -43,8 +43,10 @@ type AuthHandlerConfig struct {
 
 func NewAuthHandler(conf *AuthHandlerConfig) *AuthHandler {
 	ah := &AuthHandler{
-		DoneCh:   make(chan struct{}),
-		OutputCh: make(chan string),
+		DoneCh: make(chan struct{}),
+		// This is buffered so that if we try to output after the sink server
+		// has been shut down, during agent shutdown, we won't block
+		OutputCh: make(chan string, 1),
 		logger:   conf.Logger,
 		client:   conf.Client,
 		random:   rand.New(rand.NewSource(int64(time.Now().Nanosecond()))),