Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Reverse the order of conversion/defaults, and update HCL with more flexible defaults package into v1.3 #32607

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #32454 to be assessed for backporting due to the inclusion of the label 1.3-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


  • Update to latest version of HCL, with flexible defaults package.
  • Add test case that demonstrates failure of conversion before defaults with any type constraint.
  • Apply defaults before conversion, in line with new HCL version.

Fixes #32396

Target Release

1.3.8 / 1.3.9 / 1.4.0

Draft CHANGELOG entry

BUG FIXES

  • Fix terraform crash when applying defaults into a collection with dynamic type constraint.

@teamterraform teamterraform force-pushed the backport/liamcervante/32396/unduly-new-coral branch from 354a743 to 991fd9e Compare January 31, 2023 11:37
@teamterraform teamterraform force-pushed the backport/liamcervante/32396/unduly-new-coral branch from 991fd9e to 354a743 Compare January 31, 2023 11:37
@liamcervante liamcervante merged commit 61169a4 into v1.3 Jan 31, 2023
@liamcervante liamcervante deleted the backport/liamcervante/32396/unduly-new-coral branch January 31, 2023 12:06
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants