Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse the order of conversion/defaults, and update HCL with more flexible defaults package #32454

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Jan 4, 2023

  • Update to latest version of HCL, with flexible defaults package.
  • Add test case that demonstrates failure of conversion before defaults with any type constraint.
  • Apply defaults before conversion, in line with new HCL version.

Fixes #32396

Target Release

1.3.8 / 1.3.9 / 1.4.0

Draft CHANGELOG entry

BUG FIXES

  • Fix terraform crash when applying defaults into a collection with dynamic type constraint.

@alisdair
Copy link
Contributor

@liamcervante I just released HCL v2.16.0, so this PR can be updated and merged (and backported?)

@alisdair alisdair marked this pull request as ready for review January 30, 2023 16:23
@alisdair alisdair added the 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jan 30, 2023
@liamcervante liamcervante merged commit 24b88b7 into main Jan 31, 2023
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@liamcervante liamcervante deleted the liamcervante/32396 branch February 17, 2023 12:12
genx7up pushed a commit to aweps/terraform that referenced this pull request Mar 17, 2023
…exible defaults package (hashicorp#32454)

* Add failing test case for the given issue

* pause

* don't use local when sending PR for review

* go get github.com/hashicorp/hcl/[email protected]

* Update go.mod

---------

Co-authored-by: Alisdair McDiarmid <[email protected]>
genx7up pushed a commit to aweps/terraform that referenced this pull request Mar 17, 2023
…exible defaults package (hashicorp#32454)

* Add failing test case for the given issue

* pause

* don't use local when sending PR for review

* go get github.com/hashicorp/hcl/[email protected]

* Update go.mod

---------

Co-authored-by: Alisdair McDiarmid <[email protected]>
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 1.3.6 crashes when using optional types for list(map(any))
2 participants